Opened 14 years ago

Closed 13 years ago

#923 closed defect (fixed)

colorPicker face lift & localisation

Reported by: ray Owned by: ray
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: normal Keywords:


  • make colorPicker use the Xinha look & feel incl. skins
  • some adjusting of the buttons
  • add localisation (in Xinha main language file, see lang/de.js)
  • load using plugin api depending on the existence of hilitecolor or forecolor in the toolbar (gogo look at the _pluginInfo, is it alright?)
  • correct url to modules folder in EFM, IM, FullPage?

Change History (5)

comment:1 Changed 14 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

commited rev [700]

comment:2 Changed 14 years ago by wymsy

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ray, this color picker was originally written by Gogo as a standalone widget that could be used in other environments than just Xinha, and in fact I do use it in other parts of my application outside of Xinha, as well as in modified versions of the TableOperations? and HorizontalRule? plugins. By changing it to a plugin and incorporating Xinha functions, you have limited its use. Might it be possible to retain the standalone nature of ColorPicker?.js and wrap it in a plugin to achieve what you are trying to do here?

comment:3 Changed 14 years ago by ray

Well, partly. The localisation could probably done by changing the strings (few as they are) on the fly. That would make the Xinha._lc() calls unnecessary.

But I have changed many styles from inline js to class names (.dialog). This affects mainly the backgound-color. Unfortunately without background color, it's unusable... Is there a way to apply js style definitions only if no style is assigned by CSS?

After all I think it's ok to treat this as a "module" of Xinha (that is an integral part of it).

I can attach a "standalone version" here that incorporates the modified buttons (I think they look really better, cleaner now), that you can keep in another place outside of Xinha

comment:4 Changed 14 years ago by ray

rev [704]: I changed the name of the "module" version of colorPicker to Xinha.colorPicker to prevent a namespace clash when using a standalone version in the same page

comment:5 Changed 13 years ago by ray

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.