Opened 14 years ago

Closed 14 years ago

#458 closed defect (fixed)

Plugin NoteServer - Problem adding GUIDO code

Reported by: chris28 Owned by: gogo
Priority: normal Milestone:
Component: Plugin_Other Version:
Severity: minor Keywords: NoteServer
Cc:

Description

I use actually NoteServer? Plugin with Htmlarea in my Website. I've test it with xinha and i've this error whent i ask to insert GUIDO Code :

Erreur : NoteServer?._lc is not a function

Fichier Source : http://127.0.0.1:40/xinha-nightly/plugins/NoteServer/note-server.js

Ligne : 182

if (param["f_affcode"]) string2 = string2 + '''_lc("NoteServer")''' + ":"  + param["f_code"] + "<br>";

if (param["f_midi"]) string2 = string2 + "<a href=" + stringmidi + ">" + '''_lc("NodeServer")''' + "</a> <br>";

It works when I replace _lc("NoteServer?") by "GUIDO Code" (without translation system) and with i18nSourceCode? in Htmlarea.

PS : thanks for your work to adapt this plugin to Xinha.

RICHARD Christophe

Attachments (3)

fr.js (901 bytes) - added by chris28 14 years ago.
complete french file lang to NoteServer? plugin
note-server.js (6.8 KB) - added by chris28 14 years ago.
note-server.js with modifications to resolve _lc problem
full_example-menu.html (5.6 KB) - added by chris28 14 years ago.
example to test NoteServer? plugin

Download all attachments as: .zip

Change History (10)

comment:1 Changed 14 years ago by mharrisonline

It's a very amazing and cool plugin, and GUIDO notation is actually fairly intuitive. I never imagined anything like that was even possible before seeing it.

comment:2 Changed 14 years ago by gocher

HTMLArea works with a translation system i18nSourceCode?
and Xinha works with HTMLArea._lc("PluginName?","SourceCode?"].

Look at Line 44 in note-server.js

NoteServer.prototype._lc = function(string) {
  return HTMLArea._lc(string, 'NoteServer');
}

HTMLArea must have a function _lc else it doesn't works!

comment:3 Changed 14 years ago by gocher

HTMLArea works with a translation system i18nSourceCode?
and Xinha works with HTMLArea._lc("SourceCode?","PluginName?").

Look at Line 44 in note-server.js

NoteServer.prototype._lc = function(string) {
  return HTMLArea._lc(string, 'NoteServer');
}

HTMLArea must have a function _lc else it doesn't works!

comment:4 Changed 14 years ago by niko

  • Resolution set to fixed
  • Status changed from new to closed

i think i fixed the problem in changeset:298
(i actually didn't test it as i don't know how this plugins works :D)
please reopen if not...

comment:5 Changed 14 years ago by chris28

There is always a _lc fonction problem with changeset:298.

To resolve it i use directly :

if (param["f_affcode"]) string2 = string2 + HTMLArea._lc("GUIDO Code","NoteServer") + " : "  + param["f_code"] + "<br>";

if (param["f_midi"]) string2 = string2 + "<a href=" + stringmidi + ">" + HTMLArea._lc("MIDI File","NoteServer") + "</a> <br>";

I have translate completely fr.js and i've test it.
I think it's OK. There is just a problem when guido code source is too long with internet explorer : image is invisible because his url length > 2046 characters.

RICHARD Christophe.

Changed 14 years ago by chris28

complete french file lang to NoteServer? plugin

Changed 14 years ago by chris28

note-server.js with modifications to resolve _lc problem

Changed 14 years ago by chris28

example to test NoteServer? plugin

comment:6 Changed 14 years ago by chris28

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm sorry, i had forgotten to reopen the ticket.

comment:7 Changed 14 years ago by gocher

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in Changeset 311

Note: See TracTickets for help on using tickets.