Opened 15 years ago

Closed 14 years ago

#279 closed defect (fixed)

mistake in Flowable Toolbar

Reported by: gocher Owned by: gogo
Priority: high Milestone: Version 1.0
Component: Xinha Core Version: trunk
Severity: normal Keywords: Flowable Toolbar
Cc:

Description

The toolbar will re-flow when you resize the window, but not accurate.

Attachments (3)

test.gif (14.9 KB) - added by gocher 15 years ago.
look at this
XinhaFirefox-1.0.6.tiff (19.3 KB) - added by anonymous 14 years ago.
XinhaMozilla-1.7.3.tiff (21.9 KB) - added by anonymous 14 years ago.

Download all attachments as: .zip

Change History (14)

Changed 15 years ago by gocher

look at this

comment:1 Changed 15 years ago by gocher

If a button was/is active the button gets a border, and this border changes the size of the table/div!

comment:2 Changed 15 years ago by mokhet

this "patch" fix the problem here (add solid in the border declaration in the skin :) example

this is not happening (at least on my side) with original colors.

Index: skins/blue-look/skin.css
===================================================================
--- skins/blue-look/skin.css	(revision 187)
+++ skins/blue-look/skin.css	(working copy)
@@ -19,7 +19,7 @@
   width:20px;
   height:20px;
   padding:0px;
-  border:1px #f7f8fd;
+  border:1px solid #f7f8fd;
 }
 
 .buttonImageContainer

comment:3 Changed 15 years ago by gocher

if the background is one color it's ok, but if it's a gradient?

comment:5 Changed 15 years ago by gogo

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 15 years ago by gogo

Changed 14 years ago by anonymous

Changed 14 years ago by anonymous

comment:7 Changed 14 years ago by anonymous

  • Resolution fixed deleted
  • Status changed from closed to reopened

this is still happening in yesterday's download of nightly build 20050727.
i tried with mozilla 1.7.3 (Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.3) Gecko/20040910)

at the same time it doesn't happen on firefox 1.0.6 on the same OSX plateform.

comment:8 Changed 14 years ago by gogo

I think the trouble is that we cannot specify a height on the selects, which stuffs things up. the reason we can't specify a height is that it triggers a bug in Gecko whereby the selects will "grow" horizontally as they are reflowed.

comment:9 Changed 14 years ago by jkronika@…

I haven't tracked Xinha for long, but I do work with CSS a lot. Perhaps fiddling with the font-size for the SELECTs would help? It might require some browser sniffing to get it to work properly on all browsers/platforms, but this is a potential solution. For instance:

var selects = document.getElementById(TOOLBAR_AREA_ID_HERE).getElementsByTagName('select');
var agent = navigator.userAgent.toLowerCase(),
    is_mac = agent.indexOf('mac') > -1,
    is_win = agent.indexOf('win') > -1,
    is_ff = agent.indexOf('firefox') > -1,
    is_saf = agent.indexOf('safari') > -1,
    is_op = agent.indexOf('opera') > -1,
    is_ie = agent.indexOf('msie') > -1 && !is_op,
    is_moz = agent.indexOf('mozilla') > -1 && !is_ff && !is_saf;
for (var i = 0; i < selects.length; i++) {
 if(is_mac) {
  if(is_ff) selects[i].style.fontSize = 12px;
  else if(is_saf) ...
  ...
 } else if(is_win) {
  ...
 } else { ... }
}

comment:10 Changed 14 years ago by gocher

fixed at revision: 321

comment:11 Changed 14 years ago by gocher

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.