Opened 15 years ago

Closed 15 years ago

#256 closed defect (invalid)

Forms plugin

Reported by: wymsy Owned by: guillaumed
Priority: normal Milestone: Version 1.0
Component: Xinha Core Version:
Severity: normal Keywords: forms
Cc:

Description

I am attaching a plugin for creating html forms in xinha. It requires a few small changes to htmlarea.js to work correctly.

  1. Add textarea and form to HTMLArea._closingTags (line 3993 in version 119):
    HTMLArea._closingTags = " head script style div span tr td tbody table em strong b i code cite dfn abbr acronym font a title textarea form ";
    
  2. Fix the problem with value attributes being dropped (line 4090)(see ticket #6):
    if (!a.specified && !(a.nodeName.toLowerCase()=="value" && a.nodeValue!="")) {
    
  3. Change line 4135 from
            	html += " " + name + '="' + HTMLArea.htmlEncode(value) + '"';
    

to

        if (name=="checked" || name=="multiple")
            html += " " + name;
        else
            html += " " + name + '="' + HTMLArea.htmlEncode(value) + '"';

It would be nice to get these into the version 1 release. As I said, the plugin won't work without them.

Attachments (1)

Forms.zip (11.3 KB) - added by wymsy 15 years ago.
Forms plugin

Download all attachments as: .zip

Change History (5)

Changed 15 years ago by wymsy

Forms plugin

comment:1 Changed 15 years ago by guillaumed

  • Owner changed from gogo to guillaumed

comment:2 Changed 15 years ago by guillaumed

gogo

there are two form plugins.. In general, when there are two plugins, I think we should only consider one as the referenced in the version and let the other one open (I don't know the good translation to say let it to the owner..)..

So what should we do in this case?

comment:3 Changed 15 years ago by gogo

This plugin seems to be an old version of the one that gocher has checked in ( changeset:191 )

In future cases of plugin-name-clashes it should be easy enough to pick one of the plugins (the new one probably) and rename it to something else. Not much other way around it. (I think that's what you're asking).

Anyway, you can close this as invalid.

comment:4 Changed 15 years ago by guillaumed

  • Resolution set to invalid
  • Status changed from new to closed

I like to close ticket so easily :-)

My remark was not on the plugin-name-clash, which can be resolved simply as you proposed, but to have a selected list of "uptodate plugin" approved by Xinha and more we can not identicals.

So following this idea you should discard it from the Xinha plugin list to put it in the "Legacy htmlArea" one or at least create a second list of "other plugins"

Note: See TracTickets for help on using tickets.