Opened 7 years ago

Closed 7 years ago

#1556 closed defect (fixed)

editor._insertTable is not a function

Reported by: ejucovy Owned by: gogo
Priority: normal Milestone: 0.97
Component: Xinha Core Version: trunk
Severity: normal Keywords:
Cc:

Description

Similar to #1553.

XinhaCore.js expects to be able to call editor._insertTable to handle editor.execCommand("inserttable").

Xinha core does not define _insertTable itself -- instead it assumes a plugin or module will define the method.

However, the InsertTable module does not define the method -- instead it replaces the button action for "inserttable" directly.

Like with #1553, we should fix InsertTable to define editor._insertTable so that editor.execCommand("inserttable") works again, and so that there is a standard way for plugins to customize the table-insertion user experience.

Change History (1)

comment:1 Changed 7 years ago by ejucovy

  • Resolution set to fixed
  • Status changed from new to closed

Done in r1272.

Though, this is less important (or less interesting) than the #1553 case, because no plugins actually override the behavior.

The TableOperations plugin moves the "inserttable" button around in the toolbar, but it doesn't redefine it. It adds additional buttons, but the "inserttable" button still gets its definition from modules/InsertTable.

Note: See TracTickets for help on using tickets.