Opened 12 years ago

Closed 3 years ago

#1403 closed defect (wontfix)

baseHref not stripped in Edit Link

Reported by: guest Owned by: gogo
Priority: normal Milestone: 0.97
Component: Xinha Core Version: trunk
Severity: normal Keywords: baseHref edit link


When editing a link the directory component of baseHref is not stripped.

For example baseHref is

When editing a link the URL inserted is /something/index.php

I fixed this in XinhaCore?.js on line 2957 by replacing "$1" with this.config.baseHref

var _1d4=this.config.baseHref.replace(/(https?:\/\/[\/]+)(.*)$/,this.config.baseHref);

Change History (2)

comment:1 Changed 10 years ago by gogo

  • Milestone changed from 0.96 to 0.97

More investigation needed?

comment:2 Changed 3 years ago by gogo

  • Resolution set to wontfix
  • Status changed from new to closed

I don't think this is a problem.

The documentation comment for stripBaseHref, which this relates to, is

We can strip the server part out of URL to make/leave them semi-absolute

So, becomeing /something/foo.html is in accordance with stripBaseHref's "intended" behaviour.

People can always fix up semi-absolute url's server-side to make them relative if they want.

Note: See TracTickets for help on using tickets.