Opened 9 years ago

Closed 9 years ago

#1387 closed defect (fixed)

Misc. Bug Fix Patch

Reported by: guest Owned by: gogo
Priority: normal Milestone: 0.96
Component: Xinha Core Version: trunk
Severity: normal Keywords:
Cc:

Description

Hi,

I have successfully ported Xinha into the MyST Blogsite framework. In doing so, I tracked down and fixed a number of Xinha bugs.

The attached patch file (fas-2009-02-08.patch) contains the changes I made.

Attachments (1)

fas-2009-02-08.patch​ (5.6 KB) - added by guest 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by guest

comment:1 Changed 9 years ago by guest

Oops, forgot to leave contact info: F. Andy Seidl, faseidl@….

PS. Is there a way to register with this ticketing system so it knows who I am when I create a ticket?)

comment:2 Changed 9 years ago by gogo

changeset:1198

  • modules/insertImage/pluginMethods.js already fixed at some point
  • modules/InternetExplorer/InternetExplorer.js I've added in the patch, if it's preventing a crash I see no good reason to with-hold
  • plugins/ContextMenu/ContextMenu.js - patch not applied, _insertImage() is correct I think
  • plugins/ContextMenu/menu.css - patch applied, can't see any harm
  • popups/editor_help.html - patch applied, agree for the end user "Editor" is better than "Xinha"
  • XinhaCore?.js - saveas button patch applied, missing return applied, removal of "false" not applied, I don't think the return is checked anywhere anyway so no need to change, GET vs HEAD already dealt with in #1429

comment:3 Changed 9 years ago by gogo

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.