Changeset 1350

Timestamp:

02/04/18 00:25:44 (19 months ago)

Author:

gogo

Message:

#1480 - Fix some InsertAnchor? oddities

InsertAnchor? now does not preserve the selection (wrap the anchor around it) when inserting, this is because this made dragging anchors weird. It's better to have it just insert an atomic anchor.

Also remove the background image and just use the placeholder image, this fixes problem with bad CSS getting dumped into the anchor when it's dragged.

Location:

trunk/plugins/InsertAnchor

Files:

• InsertAnchor.js (modified) (5 diffs)
• dialog.html (modified) (1 diff)
• insert-anchor.css (modified) (1 diff)

trunk/plugins/InsertAnchor/InsertAnchor.js

@@ -4 +4 @@
   var self = this;
   
-  this.placeholderImg = '<img class="IA_placeholder" src="'+Xinha.getPluginDir("InsertAnchor")+'/img/placeholder.gif" />';
+  this.placeholderImg = '<img class="IA_placeholder" src="'+Xinha.getPluginDir("InsertAnchor")+'/img/insert-anchor.gif" />';
   
   // register the toolbar buttons provided by this plugin
@@ -83 +83 @@
                 return;
   }
+  
         var editor = this.editor;
         this.selectedHTML = editor.getSelectedHTML();
@@ -94 +95 @@
   }
   
+  this.dialog.getElementById('warning').style.display = 'none';
+  
   if (this.a != null && this.a.tagName.toLowerCase() == 'a')
   {
@@ -100 +103 @@
   else
   {
+    if(!this.editor.selectionEmpty(sel))
+    {
+      this.dialog.getElementById('warning').style.display = '';
+    }
     inputs = { name : '' };
   } 
@@ -136 +143 @@
           a.className = "anchor";
           a.innerHTML = self.placeholderImg;
-                        var html = editor.getSelectedHTML();
-                  if (html) a.innerHTML += html;
+                //      var html = editor.getSelectedHTML();
+                //  if (html) a.innerHTML += html;
                         if (Xinha.is_ie) 
                         {

trunk/plugins/InsertAnchor/dialog.html

@@ -9 +9 @@
 
 </div>
+
+<div style="margin: 10px;" id="[warning]">
+  <strong>Selected content may be replaced by the new anchor. Inserting an anchor is like inserting an image, you don't need to select anything.</strong>
+</div>
+
 <div class="buttons">
   <input type="button" id="[ok]"     value="_(OK)"     />

trunk/plugins/InsertAnchor/insert-anchor.css

@@ -2 +2 @@
   width: 18px;
   height: 18px;
+  /*
   background-image: url(img/insert-anchor.gif);
   background-repeat: no-repeat;
   background-position: left top;
   border: 1px dotted blue;
+  */
 }