Changeset 1293

Timestamp:

11/22/10 13:01:04 (1 year ago)

Author:

ejucovy

Message:

use var foo = function() instead of function foo() when defining functions inside other functions, to prevent firebug 'cannot access optimized closure' error-masking (cf http://stackoverflow.com/questions/1154315/javascript-firebug-cannot-access-optimized-closure-what-does-it-mean)

Files:

• branches/Ticket1226/paraHandlerBest.js (modified) (7 diffs)

branches/Ticket1226/paraHandlerBest.js

@@ -860 +860 @@
 EnterParagraphs.RunTests = function(xinha, debug)
 {
-  function test(message, before, cursorBefore, after, cursorAfter, cursorAfter2) {
+  var test = function(message, before, cursorBefore, after, cursorAfter, cursorAfter2) {
     console.group('Test: ', message);
     if (before !== null) {
@@ -1134 +1134 @@
   // Helper function that copies a DOM element and its attributes (except the
   // id) without any of the contents.
-  function safeShallowCopy(node, doc)
+  var safeShallowCopy = function(node, doc)
   {
     var copy = doc.createElement(node.nodeName);
@@ -1153 +1153 @@
   // node in the text is at a lower depth in the DOM tree, than we will return
   // it's first parent that is at our depth our higher in the tree.
-  function nextRootNode(node)
+  var nextRootNode = function(node)
   {
     if (node.nextSibling)
@@ -1172 +1172 @@
   // splitOffset is an offset into the text contents.  If not, it is an index
   // into the childNodes array.
-  function splitTree(root, splitNode, splitOffset, doc)
+  var splitTree = function(root, splitNode, splitOffset, doc)
   {
     // Split root into two.
@@ -1243 +1243 @@
     // An empty node is an text node of zero length or an element node with no
     // children, or whose only children are zero-length text nodes.
-    function emptyNode(node)
+    var emptyNode = function(node)
     {
       if ((TEXT_NODE == node.nodeType) && (0 == node.nodeValue.length))
@@ -1271 +1271 @@
     }
 
-    function stuffEmptyNode(node, doc)
+    var stuffEmptyNode = function(node, doc)
     {
       if (!emptyNode(node))
@@ -1313 +1313 @@
     return newCursorNode;
   }
-  function insertLineBreak(cursorParent, cursorOffset, useNewline, doc)
+  var insertLineBreak = function(cursorParent, cursorOffset, useNewline, doc)
   {
     if (TEXT_NODE == cursorParent.nodeType)