Changeset 1233

Timestamp:

01/31/10 11:43:35 (3 years ago)

Author:

gogo

Message:

TIcket #1488 fix Control Selection in IE8

Files:

• trunk/modules/InternetExplorer/InternetExplorer.js (modified) (5 diffs)

trunk/modules/InternetExplorer/InternetExplorer.js

@@ -468 +468 @@
   // object does not implement parentElement(), leading to a crash later on in the code below.  The following 
   // hack avoids that problem. 
-  if (!savedSelection.parentElement) 
-  {
-    return;
-  } 
+  
+  // Ticket #1488
+  // fix control selection in IE8
+  
+  var savedParentElement = null;
+  if (savedSelection.parentElement)
+  {
+    savedParentElement =  savedSelection.parentElement();
+  }
+  else
+  {
+    savedParentElement = savedSelection.item(0);
+  }
   
   // In order to prevent triggering the IE bug mentioned below, we will try to
@@ -478 +487 @@
   var range = this.createRange(this.getSelection());
 
+  var rangeParentElement =  null;
+  if (range.parentElement)
+  {
+    rangeParentElement =  range.parentElement();
+  }
+  else
+  {
+    rangeParentElement = range.item(0);
+  }
+
   // We can't compare two selections that come from different documents, so we
   // must make sure they're from the same document.
@@ -492 +511 @@
   }
 
-  if (findDoc(savedSelection.parentElement()) == findDoc(range.parentElement()))
+  if (savedSelection.parentElement && findDoc(savedParentElement) == findDoc(rangeParentElement))
   {
     if (range.isEqual(savedSelection))
@@ -503 +522 @@
   try { savedSelection.select() } catch (e) {};
   range = this.createRange(this.getSelection());
-  if (range.parentElement() != savedSelection.parentElement())
+  
+  if (range.parentElement)
+  {
+    rangeParentElement =  range.parentElement();
+  }
+  else
+  {
+    rangeParentElement = range.item(0);
+  }
+  
+  if (rangeParentElement != savedParentElement)
   {
     // IE has a problem with selections at the end of text nodes that
@@ -523 +552 @@
         // This workaround inserts an empty span element so that we are no
         // longer trying to select a text node,
-        var parentDoc = findDoc(savedSelection.parentElement());
+        var parentDoc = findDoc(savedParentElement);
 
         // A function used to generate a unique ID for our temporary span.